Using dotnet publish to find refs for docs #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up doc generation considerably and more reliably by relying on dotnet publish rather than trying to convice FCS to give the reference
TheAngryByrd
force-pushed
the
speed-up-docs
branch
from
077a5d7 to
5b2930b
Compare
global.json is an abomination
global.json is an abomination
global.json is an abomination
I can't convince macos gitlab runner to work with global.json so just gonna remove it for now and get the fix in net 5 when that becomes stable
TheAngryByrd
added a commit
that referenced
this pull request
Nov 11, 2020
## [0.25.1] - 2020-11-11 ### Fixed - Performance improvement of documentation generation from [@TheAngryByrd](https://github.com/TheAngryByrd) - #219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This speeds up doc generation considerably and more reliably by relying on dotnet publish rather than trying to convice FCS to give the reference.
Also updates:
Types of changes
What types of changes does your code introduce to MiniScaffold?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
This main reason for this change is speed and reliability. The code we had for FCS to pull out references to libraries could be slow on bigger projects. I think we were paying some more MSBuild costs than I wanted to and I don't know all the incantations to make FCS only do design time cracking. We also still have to build the project to get the DLL so this was extremely slow.
When using publish we pay the cost of building and references at the same time.